]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
selftests: cachestat: Fix warning on declaration under label
authorSidharth Seela <sidharthseela@gmail.com>
Mon, 29 Sep 2025 11:54:06 +0000 (17:24 +0530)
committerShuah Khan <skhan@linuxfoundation.org>
Wed, 22 Oct 2025 15:23:18 +0000 (09:23 -0600)
Fix warning caused from declaration under a case label. The proper way
is to declare variable at the beginning of the function. The warning
came from running clang using LLVM=1; and is as follows:

-test_cachestat.c:260:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
  260 |                 char *map = mmap(NULL, filesize, PROT_READ | PROT_WRITE,
      |

Link: https://lore.kernel.org/r/20250929115405.25695-2-sidharthseela@gmail.com
Signed-off-by: Sidharth Seela <sidharthseela@gmail.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Reviewed-by: wang lian <lianux.mm@gmail.com>
Reviewed-by: Dev Jain <dev.jain@arm.com>
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
Acked-by: Nhat Pham <nphamcs@gmail.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/testing/selftests/cachestat/test_cachestat.c

index c952640f163b5a2c6a7b03d36db5f2eb84061fd7..ab838bcb9ec55567190b99eb464fa85b4ba9d2eb 100644 (file)
@@ -226,7 +226,7 @@ bool run_cachestat_test(enum file_type type)
        int syscall_ret;
        size_t compute_len = PS * 512;
        struct cachestat_range cs_range = { PS, compute_len };
-       char *filename = "tmpshmcstat";
+       char *filename = "tmpshmcstat", *map;
        struct cachestat cs;
        bool ret = true;
        int fd;
@@ -257,7 +257,7 @@ bool run_cachestat_test(enum file_type type)
                }
                break;
        case FILE_MMAP:
-               char *map = mmap(NULL, filesize, PROT_READ | PROT_WRITE,
+               map = mmap(NULL, filesize, PROT_READ | PROT_WRITE,
                                 MAP_SHARED, fd, 0);
 
                if (map == MAP_FAILED) {