4.19-stable patches

added patches:
	iwlwifi-fix-softirq-hardirq-disabling-in-iwl_pcie_gen2_enqueue_hcmd.patch

diff --git a/queue-4.19/iwlwifi-fix-softirq-hardirq-disabling-in-iwl_pcie_gen2_enqueue_hcmd.patch b/queue-4.19/iwlwifi-fix-softirq-hardirq-disabling-in-iwl_pcie_gen2_enqueue_hcmd.patch
new file mode 100644 (file)
index 0000000..de2e961
--- /dev/null
+++ b/queue-4.19/iwlwifi-fix-softirq-hardirq-disabling-in-iwl_pcie_gen2_enqueue_hcmd.patch
@@ -0,0 +1,61 @@
+From e7020bb068d8be50a92f48e36b236a1a1ef9282e Mon Sep 17 00:00:00 2001
+From: Jiri Kosina <jkosina@suse.cz>
+Date: Sat, 17 Apr 2021 11:13:39 +0200
+Subject: iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_gen2_enqueue_hcmd()
+
+From: Jiri Kosina <jkosina@suse.cz>
+
+commit e7020bb068d8be50a92f48e36b236a1a1ef9282e upstream.
+
+Analogically to what we did in 2800aadc18a6 ("iwlwifi: Fix softirq/hardirq
+disabling in iwl_pcie_enqueue_hcmd()"), we must apply the same fix to
+iwl_pcie_gen2_enqueue_hcmd(), as it's being called from exactly the same
+contexts.
+
+Reported-by: Heiner Kallweit <hkallweit1@gmail.com
+Signed-off-by: Jiri Kosina <jkosina@suse.cz>
+Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
+Link: https://lore.kernel.org/r/nycvar.YFH.7.76.2104171112390.18270@cbobk.fhfr.pm
+Signed-off-by: Jari Ruusu <jariruusu@protonmail.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c |    7 ++++---
+ 1 file changed, 4 insertions(+), 3 deletions(-)
+
+--- a/drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c
++++ b/drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c
+@@ -654,6 +654,7 @@ static int iwl_pcie_gen2_enqueue_hcmd(st
+       const u8 *cmddata[IWL_MAX_CMD_TBS_PER_TFD];
+       u16 cmdlen[IWL_MAX_CMD_TBS_PER_TFD];
+       struct iwl_tfh_tfd *tfd;
++      unsigned long flags2;
+ 
+       copy_size = sizeof(struct iwl_cmd_header_wide);
+       cmd_size = sizeof(struct iwl_cmd_header_wide);
+@@ -722,14 +723,14 @@ static int iwl_pcie_gen2_enqueue_hcmd(st
+               goto free_dup_buf;
+       }
+ 
+-      spin_lock_bh(&txq->lock);
++      spin_lock_irqsave(&txq->lock, flags2);
+ 
+       idx = iwl_pcie_get_cmd_index(txq, txq->write_ptr);
+       tfd = iwl_pcie_get_tfd(trans, txq, txq->write_ptr);
+       memset(tfd, 0, sizeof(*tfd));
+ 
+       if (iwl_queue_space(trans, txq) < ((cmd->flags & CMD_ASYNC) ? 2 : 1)) {
+-              spin_unlock_bh(&txq->lock);
++              spin_unlock_irqrestore(&txq->lock, flags2);
+ 
+               IWL_ERR(trans, "No space in command queue\n");
+               iwl_op_mode_cmd_queue_full(trans->op_mode);
+@@ -870,7 +871,7 @@ static int iwl_pcie_gen2_enqueue_hcmd(st
+       spin_unlock_irqrestore(&trans_pcie->reg_lock, flags);
+ 
+ out:
+-      spin_unlock_bh(&txq->lock);
++      spin_unlock_irqrestore(&txq->lock, flags2);
+ free_dup_buf:
+       if (idx < 0)
+               kfree(dup_buf);

diff --git a/queue-4.19/series b/queue-4.19/series
index e2e26b2bf5d4b0988fbeb5ca7761ba9ad230fecc..ef502e4842d92e776451c1b37ae0a24c0502b2e1 100644 (file)
--- a/queue-4.19/series
+++ b/queue-4.19/series
@@ -5,3 +5,4 @@ net-usb-ax88179_178a-initialize-local-variables-before-use.patch
 iwlwifi-fix-softirq-hardirq-disabling-in-iwl_pcie_enqueue_hcmd.patch
 mips-do-not-include-hi-and-lo-in-clobber-list-for-r6.patch
 bpf-fix-masking-negation-logic-upon-negative-dst-register.patch
+iwlwifi-fix-softirq-hardirq-disabling-in-iwl_pcie_gen2_enqueue_hcmd.patch