]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
libblkid: use blkid_probe_set_value() in more consistent way
authorKarel Zak <kzak@redhat.com>
Mon, 31 Oct 2022 11:55:14 +0000 (12:55 +0100)
committerKarel Zak <kzak@redhat.com>
Mon, 31 Oct 2022 11:55:14 +0000 (12:55 +0100)
* use it if snprintf unnecessary
* use "const char" to be consistent

Signed-off-by: Karel Zak <kzak@redhat.com>
libblkid/src/partitions/partitions.c
libblkid/src/partitions/partitions.h
libblkid/src/superblocks/superblocks.c

index a34a446dc681c5fba4fe9579991709607330dce4..ae63a38ccad18d3861b668006dd52625a6b9e0b3 100644 (file)
@@ -1144,7 +1144,7 @@ int blkid_partitions_set_ptuuid(blkid_probe pr, unsigned char *uuid)
 
 /* set PTUUID variable for non-binary API for tables where
  * the ID is just a string */
-int blkid_partitions_strcpy_ptuuid(blkid_probe pr, char *str)
+int blkid_partitions_strcpy_ptuuid(blkid_probe pr, const char *str)
 {
        struct blkid_chain *chn = blkid_probe_get_chain(pr);
 
index 4a718f4eaa42a5183feac84d559d8c8aedb0121e..784e0c0e3349edd449b32bc2fbb3d619fe52ccd8 100644 (file)
@@ -28,7 +28,7 @@ extern int blkid_partitions_do_subprobe(blkid_probe pr,
 
 extern int blkid_partitions_need_typeonly(blkid_probe pr);
 extern int blkid_partitions_set_ptuuid(blkid_probe pr, unsigned char *uuid);
-extern int blkid_partitions_strcpy_ptuuid(blkid_probe pr, char *str);
+extern int blkid_partitions_strcpy_ptuuid(blkid_probe pr, const char *str);
 
 
 extern int blkid_is_nested_dimension(blkid_partition par,
index 1c304bc2f6c6756ab3610e1fb112ca5955ce031f..01b941173b7a794cbdcb817f875faf89d4ce68b9 100644 (file)
@@ -575,7 +575,7 @@ int blkid_probe_set_block_size(blkid_probe pr, unsigned block_size)
 static int blkid_probe_set_usage(blkid_probe pr, int usage)
 {
        struct blkid_chain *chn = blkid_probe_get_chain(pr);
-       char *u = NULL;
+       const char *u = NULL;
 
        if (!(chn->flags & BLKID_SUBLKS_USAGE))
                return 0;
@@ -591,7 +591,8 @@ static int blkid_probe_set_usage(blkid_probe pr, int usage)
        else
                u = "unknown";
 
-       return blkid_probe_set_value(pr, "USAGE", (unsigned char *) u, strlen(u) + 1);
+       return blkid_probe_set_value(pr, "USAGE",
+                       (const unsigned char *) u, strlen(u) + 1);
 }
 
 int blkid_probe_set_fssize(blkid_probe pr, uint64_t size)
@@ -629,12 +630,11 @@ int blkid_probe_set_fsblocksize(blkid_probe pr, uint32_t block_size)
 int blkid_probe_set_fsendianness(blkid_probe pr, enum BLKID_ENDIANNESS endianness)
 {
        struct blkid_chain *chn = blkid_probe_get_chain(pr);
+       const char *value;
 
        if (!(chn->flags & BLKID_SUBLKS_FSINFO))
                return 0;
 
-       const char *value;
-
        switch (endianness) {
                case BLKID_ENDIANNESS_LITTLE:
                        value = "LITTLE";
@@ -646,7 +646,9 @@ int blkid_probe_set_fsendianness(blkid_probe pr, enum BLKID_ENDIANNESS endiannes
                        return -EINVAL;
        }
 
-       return blkid_probe_sprintf_value(pr, "ENDIANNESS", "%s", value);
+       return blkid_probe_set_value(pr, "ENDIANNESS",
+                       (const unsigned char *) value, strlen(value) + 1);
+
 }
 
 int blkid_probe_set_id_label(blkid_probe pr, const char *name,