]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
basic: use -EINVAL for _MANAGED_OOM_PREFERENCE_INVALID
authorBenjamin Robin <dev@benjarobin.fr>
Tue, 16 Feb 2021 22:18:28 +0000 (23:18 +0100)
committerBenjamin Robin <dev@benjarobin.fr>
Tue, 16 Feb 2021 22:33:01 +0000 (23:33 +0100)
Follow-up of #11484

src/basic/cgroup-util.h
src/core/dbus-cgroup.c

index 420ddb59c0c507df915af58270b0af0c90d14d93..30b4819eb3d3658555c2d67ca49e0823010a1f9f 100644 (file)
@@ -297,7 +297,7 @@ typedef enum ManagedOOMPreference {
         MANAGED_OOM_PREFERENCE_AVOID = 1,
         MANAGED_OOM_PREFERENCE_OMIT = 2,
         _MANAGED_OOM_PREFERENCE_MAX,
-        _MANAGED_OOM_PREFERENCE_INVALID = -1
+        _MANAGED_OOM_PREFERENCE_INVALID = -EINVAL,
 } ManagedOOMPreference;
 
 const char* managed_oom_preference_to_string(ManagedOOMPreference a) _const_;
index 2b8b833fe39306ee34b9e6a8067343f513fac8bd..6652c212f19bde5c9321770b45e2f93c28a9d891 100644 (file)
@@ -1732,7 +1732,7 @@ int bus_cgroup_set_property(
 
                 p = managed_oom_preference_from_string(pref);
                 if (p < 0)
-                        return -EINVAL;
+                        return p;
 
                 if (!UNIT_WRITE_FLAGS_NOOP(flags)) {
                         c->moom_preference = p;