]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:winbindd: Skip check_negative_conn_cache() if saf_servername == NULL
authorPavel Filipenský <pfilipensky@samba.org>
Mon, 18 Sep 2023 09:15:21 +0000 (11:15 +0200)
committerPavel Filipensky <pfilipensky@samba.org>
Wed, 11 Oct 2023 15:37:28 +0000 (15:37 +0000)
saf_servername can be NULL even after calling saf_fetch().  Avoid
calling check_negative_conn_cache() like it was before commit 0fcf0012

Signed-off-by: Pavel Filipenský <pfilipensky@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/winbindd/winbindd_cm.c

index 13ab6754fd3be63b92c094b2faa44f641134fe94..24c68c67ff01ada79b7a3c66253d5c9b51fc8081 100644 (file)
@@ -1426,9 +1426,12 @@ static bool connect_preferred_dc(TALLOC_CTX *mem_ctx,
         * Check the negative connection cache before talking to it. It going
         * down may have triggered the reconnection.
         */
-       status = check_negative_conn_cache(domain->name, saf_servername);
-       if (!NT_STATUS_IS_OK(status)) {
-               saf_servername = NULL;
+       if (saf_servername != NULL) {
+               status = check_negative_conn_cache(domain->name,
+                                                  saf_servername);
+               if (!NT_STATUS_IS_OK(status)) {
+                       saf_servername = NULL;
+               }
        }
 
        if (saf_servername != NULL) {