]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
Improve memory cleanup in some unittests
authorVictor Julien <victor@inliniac.net>
Fri, 28 Jun 2013 10:28:51 +0000 (12:28 +0200)
committerVictor Julien <victor@inliniac.net>
Fri, 28 Jun 2013 10:28:51 +0000 (12:28 +0200)
src/app-layer-ssl.c
src/stream-tcp-reassemble.c

index 141f1360fc39df9f543c2056882c6821415e982c..9e1413851ea554a7a271fa3f06b54423ec346242 100644 (file)
@@ -2538,6 +2538,7 @@ static int SSLParserTest21(void)
 
     result = 1;
 end:
+    StreamTcpFreeConfig(TRUE);
     FLOW_DESTROY(&f);
     return result;
 }
index 2e14434567db1b834d5603e0168229daacd9e0ba..72f7818ee8166692071f49055f4edb2ea59d1f21 100644 (file)
@@ -8380,6 +8380,7 @@ static int StreamTcpReassembleInlineTest10(void) {
     ThreadVars tv;
     TcpSession ssn;
     Flow *f = NULL;
+    Packet *p = NULL;
 
     memset(&tv, 0x00, sizeof(tv));
 
@@ -8396,7 +8397,7 @@ static int StreamTcpReassembleInlineTest10(void) {
     uint8_t stream_payload2[] = "T /";
     uint8_t stream_payload3[] = "HTTP/1.0\r\n\r\n";
 
-    Packet *p = UTHBuildPacketReal(stream_payload3, 12, IPPROTO_TCP, "1.1.1.1", "2.2.2.2", 1024, 80);
+    p = UTHBuildPacketReal(stream_payload3, 12, IPPROTO_TCP, "1.1.1.1", "2.2.2.2", 1024, 80);
     if (p == NULL) {
         printf("couldn't get a packet: ");
         goto end;
@@ -8446,12 +8447,9 @@ static int StreamTcpReassembleInlineTest10(void) {
 
     ret = 1;
 end:
-#if 0
-    FLOW_DESTROY(&f);
     UTHFreePacket(p);
     StreamTcpUTClearSession(&ssn);
     StreamTcpUTDeinit(ra_ctx);
-#endif
     UTHFreeFlow(f);
     return ret;
 }