]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
Fixes platform.win32_ver on non-Windows platforms (GH-12912)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Mon, 22 Apr 2019 18:59:08 +0000 (11:59 -0700)
committerGitHub <noreply@github.com>
Mon, 22 Apr 2019 18:59:08 +0000 (11:59 -0700)
(cherry picked from commit d307d05350e26a7a5f8f74db9af632a15215b50f)

Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Lib/platform.py

index 0c6fc03efa9f815e5a927a289adf912ce8050dec..8ed2807df10900a07a163693ab35071d437a348d 100755 (executable)
@@ -535,10 +535,6 @@ def win32_ver(release='', version='', csd='', ptype=''):
         from sys import getwindowsversion
     except ImportError:
         return release, version, csd, ptype
-    try:
-        from winreg import OpenKeyEx, QueryValueEx, CloseKey, HKEY_LOCAL_MACHINE
-    except ImportError:
-        from _winreg import OpenKeyEx, QueryValueEx, CloseKey, HKEY_LOCAL_MACHINE
 
     winver = getwindowsversion()
     maj, min, build = winver.platform_version or winver[:3]
@@ -564,16 +560,20 @@ def win32_ver(release='', version='', csd='', ptype=''):
                    _WIN32_SERVER_RELEASES.get((maj, None)) or
                    release)
 
-    key = None
     try:
-        key = OpenKeyEx(HKEY_LOCAL_MACHINE,
-                        r'SOFTWARE\Microsoft\Windows NT\CurrentVersion')
-        ptype = QueryValueEx(key, 'CurrentType')[0]
-    except:
+        try:
+            import winreg
+        except ImportError:
+            import _winreg as winreg
+    except ImportError:
         pass
-    finally:
-        if key:
-            CloseKey(key)
+    else:
+        try:
+            cvkey = r'SOFTWARE\Microsoft\Windows NT\CurrentVersion'
+            with winreg.OpenKeyEx(HKEY_LOCAL_MACHINE, cvkey) as key:
+                ptype = QueryValueEx(key, 'CurrentType')[0]
+        except:
+            pass
 
     return release, version, csd, ptype