]> git.ipfire.org Git - thirdparty/vuejs/core.git/commitdiff
dx: warn use of reserved methods in render
authorEvan You <yyx990803@gmail.com>
Thu, 28 Feb 2019 17:50:18 +0000 (12:50 -0500)
committerEvan You <yyx990803@gmail.com>
Thu, 28 Feb 2019 17:50:18 +0000 (12:50 -0500)
packages/runtime-core/src/componentProxy.ts

index b5855409ef7064a2d8f6bbd5dc640451a6e92ff2..1747631d0f46bb151b4c86eea2dfa6f5a2b641c6 100644 (file)
@@ -37,16 +37,18 @@ const renderProxyHandlers = {
       // computed
       return i[key]()
     } else if (key[0] !== '_') {
-      if (
-        __DEV__ &&
-        isRendering &&
-        !(key in target) &&
-        !(key in reservedMethods)
-      ) {
-        warn(
-          `property "${key}" was accessed during render but does not exist ` +
-            `on instance.`
-        )
+      if (__DEV__ && isRendering) {
+        if (key in reservedMethods) {
+          warn(
+            `"${key}" is a reserved method / lifecycle hook and should not be ` +
+              `used as a normal method during render.`
+          )
+        } else if (!(key in target)) {
+          warn(
+            `property "${key}" was accessed during render but does not exist ` +
+              `on instance.`
+          )
+        }
       }
       const value = Reflect.get(target, key, receiver)
       if (key !== 'constructor' && isFunction(value)) {