staging: rtl8723bs: remove custom is_zero_mac_addr() function

Remove the custom function is_zero_mac_addr() and replace all calls to it
with the default kernel function is_zero_ether_addr() to avoid
duplicating existing code.

Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
Link: https://patch.msgid.link/20260323150650.7168-5-nikolayof23@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
index eb4a32a998aeec6d3b8ccc40f14cdf377759f849..c20a143ace4b9a0fbff1d8833bff241f6073ed1e 100644 (file)
--- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
@@ -11,7 +11,7 @@ u8 rtw_validate_bssid(u8 *bssid)
 {
        u8 ret = true;
 
-       if (is_zero_mac_addr(bssid) ||
+       if (is_zero_ether_addr(bssid) ||
            is_broadcast_mac_addr(bssid) ||
            is_multicast_mac_addr(bssid))
                ret = false;

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 2a4dbce8142e575e10a36ca99354f98b1f570132..ddfc56f0253dfdffaac72ecc655bd88a0d56ac98 100644 (file)
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -1675,7 +1675,7 @@ static int rtw_check_roaming_candidate(struct mlme_priv *mlme
                goto exit;
 
        /* got specific addr to roam */
-       if (!is_zero_mac_addr(mlme->roam_tgt_addr)) {
+       if (!is_zero_ether_addr(mlme->roam_tgt_addr)) {
                if (!memcmp(mlme->roam_tgt_addr, competitor->network.mac_address, ETH_ALEN))
                        goto update;
                else

diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/staging/rtl8723bs/include/ieee80211.h
index 14c806a22b38e727174e4e723e0e5dafa198ec8c..37b9b363c073e891c932111ed4a24fbb4622e022 100644 (file)
--- a/drivers/staging/rtl8723bs/include/ieee80211.h
+++ b/drivers/staging/rtl8723bs/include/ieee80211.h
@@ -518,12 +518,6 @@ static inline int is_broadcast_mac_addr(const u8 *addr)
                (addr[3] == 0xff) && (addr[4] == 0xff) && (addr[5] == 0xff));
 }
 
-static inline int is_zero_mac_addr(const u8 *addr)
-{
-       return ((addr[0] == 0x00) && (addr[1] == 0x00) && (addr[2] == 0x00) &&   \
-               (addr[3] == 0x00) && (addr[4] == 0x00) && (addr[5] == 0x00));
-}
-
 #define CFG_IEEE80211_RESERVE_FCS (1<<0)
 #define CFG_IEEE80211_COMPUTE_FCS (1<<1)