]> git.ipfire.org Git - thirdparty/openwrt.git/commitdiff
realtek: rtl838x: fix regression in enable_phy_polling 20549/head
authorFelix Baumann <felix.bau@gmx.de>
Sun, 26 Oct 2025 01:54:14 +0000 (02:54 +0100)
committerRobert Marko <robimarko@gmail.com>
Tue, 28 Oct 2025 09:11:32 +0000 (10:11 +0100)
Fix regression from back when support for RTL930x was added.
While at it replace 0x8000 by BIT(15).

Fixes: 27029277f98ddd0006175bdc5beec8b0b150f187
Tested-by: Jonas Jelonek <jelonek.jonas@gmail.com>
Signed-off-by: Felix Baumann <felix.bau@gmx.de>
Link: https://github.com/openwrt/openwrt/pull/20549
Signed-off-by: Robert Marko <robimarko@gmail.com>
target/linux/realtek/files-6.12/drivers/net/dsa/rtl83xx/dsa.c

index f05aa2313e7a92533f9f8427bbcbcb522eff5662..0e5e79c45d00d89d1b14e964fbaeb59978e88461 100644 (file)
@@ -58,11 +58,11 @@ static void rtl83xx_enable_phy_polling(struct rtl838x_switch_priv *priv)
        pr_info("%s: %16llx\n", __func__, v);
        priv->r->set_port_reg_le(v, priv->r->smi_poll_ctrl);
 
-       /* PHY update complete, there is no global PHY polling enable bit on the 9300 */
+       /* PHY update complete, there is no global PHY polling enable bit on the 93xx */
        if (priv->family_id == RTL8390_FAMILY_ID)
                sw_w32_mask(0, BIT(7), RTL839X_SMI_GLB_CTRL);
-       else if(priv->family_id == RTL9300_FAMILY_ID)
-               sw_w32_mask(0, 0x8000, RTL838X_SMI_GLB_CTRL);
+       else if(priv->family_id == RTL8380_FAMILY_ID)
+               sw_w32_mask(0, BIT(15), RTL838X_SMI_GLB_CTRL);
 }
 
 const struct rtldsa_mib_list_item rtldsa_838x_mib_list[] = {