]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/ssd130x: Use kmalloc_array() instead of kmalloc()
authorJames Flowers <bold.zone2373@fastmail.com>
Sun, 14 Sep 2025 07:38:22 +0000 (00:38 -0700)
committerJavier Martinez Canillas <javierm@redhat.com>
Wed, 17 Sep 2025 10:16:19 +0000 (12:16 +0200)
Documentation/process/deprecated.rst recommends against the use of
kmalloc with dynamic size calculations due to the risk of overflow and
smaller allocation being made than the caller was expecting.
kmalloc_array avoids this issue.

Signed-off-by: James Flowers <bold.zone2373@fastmail.com>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://lore.kernel.org/r/20250914073841.69582-1-bold.zone2373@fastmail.com
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
drivers/gpu/drm/solomon/ssd130x.c

index eec43d1a55951b7a5fe00d27a2a0572eed6011e1..8368f0ffbe1edc67e75b1bbcc2c21daf4dba1319 100644 (file)
@@ -1498,7 +1498,7 @@ static int ssd130x_crtc_atomic_check(struct drm_crtc *crtc,
        if (ret)
                return ret;
 
-       ssd130x_state->data_array = kmalloc(ssd130x->width * pages, GFP_KERNEL);
+       ssd130x_state->data_array = kmalloc_array(ssd130x->width, pages, GFP_KERNEL);
        if (!ssd130x_state->data_array)
                return -ENOMEM;
 
@@ -1519,7 +1519,7 @@ static int ssd132x_crtc_atomic_check(struct drm_crtc *crtc,
        if (ret)
                return ret;
 
-       ssd130x_state->data_array = kmalloc(columns * ssd130x->height, GFP_KERNEL);
+       ssd130x_state->data_array = kmalloc_array(columns, ssd130x->height, GFP_KERNEL);
        if (!ssd130x_state->data_array)
                return -ENOMEM;
 
@@ -1546,7 +1546,7 @@ static int ssd133x_crtc_atomic_check(struct drm_crtc *crtc,
 
        pitch = drm_format_info_min_pitch(fi, 0, ssd130x->width);
 
-       ssd130x_state->data_array = kmalloc(pitch * ssd130x->height, GFP_KERNEL);
+       ssd130x_state->data_array = kmalloc_array(pitch, ssd130x->height, GFP_KERNEL);
        if (!ssd130x_state->data_array)
                return -ENOMEM;