]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
nouveau/gsp: drop WARN_ON in ACPI probes
authorDave Airlie <airlied@redhat.com>
Thu, 21 Nov 2024 01:46:01 +0000 (11:46 +1000)
committerDanilo Krummrich <dakr@kernel.org>
Mon, 16 Feb 2026 21:51:24 +0000 (22:51 +0100)
These WARN_ONs seem to trigger a lot, and we don't seem to have a
plan to fix them, so just drop them, as they are most likely
harmless.

Cc: stable@vger.kernel.org
Fixes: 176fdcbddfd2 ("drm/nouveau/gsp/r535: add support for booting GSP-RM")
Signed-off-by: Dave Airlie <airlied@redhat.com>
Link: https://patch.msgid.link/20241121014601.229391-1-airlied@gmail.com
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c

index 7fb13434c051de931ab38bfd187b00a332da50a4..a575a8dbf727df1373c690f070bc5d951680c1f4 100644 (file)
@@ -737,8 +737,8 @@ r535_gsp_acpi_caps(acpi_handle handle, CAPS_METHOD_DATA *caps)
        if (!obj)
                goto done;
 
-       if (WARN_ON(obj->type != ACPI_TYPE_BUFFER) ||
-           WARN_ON(obj->buffer.length != 4))
+       if (obj->type != ACPI_TYPE_BUFFER ||
+           obj->buffer.length != 4)
                goto done;
 
        caps->status = 0;
@@ -773,8 +773,8 @@ r535_gsp_acpi_jt(acpi_handle handle, JT_METHOD_DATA *jt)
        if (!obj)
                goto done;
 
-       if (WARN_ON(obj->type != ACPI_TYPE_BUFFER) ||
-           WARN_ON(obj->buffer.length != 4))
+       if (obj->type != ACPI_TYPE_BUFFER ||
+           obj->buffer.length != 4)
                goto done;
 
        jt->status = 0;
@@ -861,8 +861,8 @@ r535_gsp_acpi_dod(acpi_handle handle, DOD_METHOD_DATA *dod)
 
        _DOD = output.pointer;
 
-       if (WARN_ON(_DOD->type != ACPI_TYPE_PACKAGE) ||
-           WARN_ON(_DOD->package.count > ARRAY_SIZE(dod->acpiIdList)))
+       if (_DOD->type != ACPI_TYPE_PACKAGE ||
+           _DOD->package.count > ARRAY_SIZE(dod->acpiIdList))
                return;
 
        for (int i = 0; i < _DOD->package.count; i++) {