]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
um: Fix return value in ubd_init()
authorDuoming Zhou <duoming@zju.edu.cn>
Wed, 6 Mar 2024 09:12:59 +0000 (17:12 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 16 Jun 2024 11:28:44 +0000 (13:28 +0200)
[ Upstream commit 31a5990ed253a66712d7ddc29c92d297a991fdf2 ]

When kmalloc_array() fails to allocate memory, the ubd_init()
should return -ENOMEM instead of -1. So, fix it.

Fixes: f88f0bdfc32f ("um: UBD Improvements")
Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/um/drivers/ubd_kern.c

index 4e59ab817d3e7539134fc93a75f8b2f8826ea8fd..a4e531f0e3b96fa79c9d0b7033f623ba36678216 100644 (file)
@@ -1157,7 +1157,7 @@ static int __init ubd_init(void)
 
        if (irq_req_buffer == NULL) {
                printk(KERN_ERR "Failed to initialize ubd buffering\n");
-               return -1;
+               return -ENOMEM;
        }
        io_req_buffer = kmalloc_array(UBD_REQ_BUFFER_SIZE,
                                      sizeof(struct io_thread_req *),
@@ -1168,7 +1168,7 @@ static int __init ubd_init(void)
 
        if (io_req_buffer == NULL) {
                printk(KERN_ERR "Failed to initialize ubd buffering\n");
-               return -1;
+               return -ENOMEM;
        }
        platform_driver_register(&ubd_driver);
        mutex_lock(&ubd_lock);