]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ASoC: wm_adsp_fw_find_test: Fix missing NULL terminator on file name list
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Thu, 26 Mar 2026 10:08:53 +0000 (10:08 +0000)
committerMark Brown <broonie@kernel.org>
Thu, 26 Mar 2026 10:44:45 +0000 (10:44 +0000)
The array wm_adsp_fw_find_test_dir_all_files[] needs a NULL terminator.

It was documented at line 41 that dir_files points to a NULL-terminated
array.

   /* NULL-terminated array of pointers to filenames ... <snip> */
   const char * const *dir_files;

This fixes the error reported by KASAN:

[17:46:43] BUG: KASAN: global-out-of-bounds in
  wm_adsp_fw_find_test_pick_file+0x8cc/0xc80
[17:46:43] Read of size 8 at addr ffff800081e5ffe8 by task
  kunit_try_catch/18349

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: bf2d44d07de7 ("ASoC: wm_adsp: Add kunit test for firmware file search")
Link: https://patch.msgid.link/20260326100853.1582886-1-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm_adsp_fw_find_test.c

index fb886dc61c27a83f94ca243ac499cf138523fcce..d0c7fb30a95dca6615aa063d8e6c6fc03d09c7a4 100644 (file)
@@ -1041,6 +1041,7 @@ static const char * const wm_adsp_fw_find_test_dir_all_files[] = {
        "cirrus/cs1234-dsp1-mbc-vss.bin",
        "cirrus/wm1234-dsp1-mbc-vss.bin",
        "wm1234-dsp1-mbc-vss.bin",
+       NULL /* terminator */
 };
 
 /*