]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
memory: tegra124-emc: Fix dll_change check
authorMikko Perttunen <mperttunen@nvidia.com>
Mon, 26 Jan 2026 06:50:42 +0000 (15:50 +0900)
committerKrzysztof Kozlowski <krzk@kernel.org>
Tue, 24 Feb 2026 11:02:14 +0000 (12:02 +0100)
The code checking whether the specified memory timing enables DLL
in the EMRS register was reversed. DLL is enabled if bit A0 is low.
Fix the check.

Fixes: 73a7f0a90641 ("memory: tegra: Add EMC (external memory controller) driver")
Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
Link: https://patch.msgid.link/20260126-fix-emc-dllchange-v1-1-47ad3bb63262@nvidia.com
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
drivers/memory/tegra/tegra124-emc.c

index ff26815e51f17f36e1a305cd341ede5a676a0855..5cfbc169c5f988ebc92155771d32742fe44e1ea2 100644 (file)
@@ -608,7 +608,7 @@ static int tegra124_emc_prepare_timing_change(struct tegra_emc *emc,
 
        if ((last->emc_mode_1 & 0x1) == (timing->emc_mode_1 & 0x1))
                dll_change = DLL_CHANGE_NONE;
-       else if (timing->emc_mode_1 & 0x1)
+       else if (!(timing->emc_mode_1 & 0x1))
                dll_change = DLL_CHANGE_ON;
        else
                dll_change = DLL_CHANGE_OFF;