]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
cgroup-util: explain why cg_pidref_get_path() cannot be ported over to pidfd helpers... 35242/head
authorMike Yuan <me@yhndnzj.com>
Fri, 29 Nov 2024 16:13:18 +0000 (17:13 +0100)
committerMike Yuan <me@yhndnzj.com>
Sat, 4 Jan 2025 16:48:23 +0000 (17:48 +0100)
See also: https://github.com/systemd/systemd/pull/35242#issuecomment-2506686806

src/basic/cgroup-util.c

index 50f1f0e4df2c3e809e8e464962535354ec2c6980..1d2faa7393f5a7de2ab4bfa56e2d335d41d314a8 100644 (file)
@@ -861,6 +861,10 @@ int cg_pidref_get_path(const char *controller, const PidRef *pidref, char **ret_
         if (!pidref_is_set(pidref))
                 return -ESRCH;
 
+        // XXX: Ideally we'd use pidfd_get_cgroupid() + cg_path_from_cgroupid() here, to extract this
+        // bit of information from pidfd directly. However, the latter requires privilege and it's
+        // not entirely clear how to handle cgroups from outer namespace.
+
         r = cg_pid_get_path(controller, pidref->pid, &path);
         if (r < 0)
                 return r;