Fix a function cleanup bug in dns_request_createraw

When get_dispatch() returns an error code, the dns_request_createraw()
function jumps to the `cleanup` label, which will leave a previous
attachment to the `request` pointer unattached.

Fix the issue by jumping to the `detach` label instead.

diff --git a/lib/dns/request.c b/lib/dns/request.c
index 49a95e11625b692b8d2189c1deb397ecf4cc6073..f0047b145b405ac0c340613681e04c9bd0c9037d 100644 (file)
--- a/lib/dns/request.c
+++ b/lib/dns/request.c
@@ -558,7 +558,7 @@ again:
        result = get_dispatch(tcp, newtcp, requestmgr, srcaddr, destaddr, dscp,
                              &connected, &request->dispatch);
        if (result != ISC_R_SUCCESS) {
-               goto cleanup;
+               goto detach;
        }
 
        if ((options & DNS_REQUESTOPT_FIXEDID) != 0) {