Fix the fencepost issue when we check stability_last_downrated

diff --git a/changes/bug40394 b/changes/bug40394
new file mode 100644 (file)
index 0000000..f55167f
--- /dev/null
+++ b/changes/bug40394
@@ -0,0 +1,4 @@
+  o Minor bugfixes (statistics):
+    - Fix the fencepost issue when we check stability_last_downrated where
+      we call rep_hist_downrate_old_runs() twice. Fixes bug 40394; bugfix
+      on 0.2.0.5-alpha. Patch by Neel Chauhan.

diff --git a/src/feature/stats/rephist.c b/src/feature/stats/rephist.c
index 50f6a11ae1c76fb04812d38fc0fb5b0dda44dfa4..59d5313cc8d4342400989b72b73f8525161df5c1 100644 (file)
--- a/src/feature/stats/rephist.c
+++ b/src/feature/stats/rephist.c
@@ -731,7 +731,7 @@ rep_hist_downrate_old_runs(time_t now)
     return stability_last_downrated + STABILITY_INTERVAL;
 
   /* Okay, we should downrate the data.  By how much? */
-  while (stability_last_downrated + STABILITY_INTERVAL < now) {
+  while (stability_last_downrated + STABILITY_INTERVAL <= now) {
     stability_last_downrated += STABILITY_INTERVAL;
     alpha *= STABILITY_ALPHA;
   }