bpo-39600: Adjust code, add idlelib/NEWS item (GH-18449)

Complete previous patch.

diff --git a/Lib/idlelib/NEWS.txt b/Lib/idlelib/NEWS.txt
index d57ba7e6bac908c0b9f803729ffc6df6412fb473..838120964b2d893197ca2d67f8d8f8fe4d41eae3 100644 (file)
--- a/Lib/idlelib/NEWS.txt
+++ b/Lib/idlelib/NEWS.txt
@@ -3,6 +3,8 @@ Released on 2020-10-05?
 ======================================
 
 
+bpo-39600: Remove duplicate font names from configuration list.
+
 bpo-38792: Close a shell calltip if a :exc:`KeyboardInterrupt`
 or shell restart occurs.  Patch by Zackery Spytz.
 

diff --git a/Lib/idlelib/configdialog.py b/Lib/idlelib/configdialog.py
index 7b844f00e7736d7e903758f2d1af5c634f589702..9d5c2cde04b2404e5c72f61d33cd1321543b7402 100644 (file)
--- a/Lib/idlelib/configdialog.py
+++ b/Lib/idlelib/configdialog.py
@@ -606,10 +606,8 @@ class FontPage(Frame):
         font_size = configured_font[1]
         font_bold  = configured_font[2]=='bold'
 
-        # Set editor font selection list and font_name.
-        fonts = tkFont.families(self)
-        # remove duplicated names and sort
-        fonts = sorted(set(fonts))
+        # Set sorted no-duplicate editor font selection list and font_name.
+        fonts = sorted(set(tkFont.families(self)))
         for font in fonts:
             self.fontlist.insert(END, font)
         self.font_name.set(font_name)