s3: libsmb: Cleanup - use early return in get_dc_list().

No logic change. Makes later code changes clearer.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Noel Power <npower@samba.org>

diff --git a/source3/libsmb/namequery.c b/source3/libsmb/namequery.c
index 06472dcffb5e88a08f5af89ea474385ef7500896..a70837db2baafa34c835ca4e643df20d87b075e7 100644 (file)
--- a/source3/libsmb/namequery.c
+++ b/source3/libsmb/namequery.c
@@ -3832,9 +3832,10 @@ static NTSTATUS get_dc_list(const char *domain,
                        status = NT_STATUS_INVALID_PARAMETER;
                        goto out;
                }
-               if (NT_STATUS_IS_OK(status)) {
-                       *ret_count = (size_t)tmp_count;
+               if (!NT_STATUS_IS_OK(status)) {
+                       goto out;
                }
+               *ret_count = (size_t)tmp_count;
                goto out;
        }