This is the fix for the PAM bug I probably introduced in the previous commit,

which I will confirm once I can find a box it would break on in the first place.

(this is the pam accounts as nobody thing we had with 2.2.0)

Andrew Bartlett

diff --git a/source/auth/auth.c b/source/auth/auth.c
index 851e1f53cffc664ca716fb1a4aa1471c26d9c3a6..4bfbfe65fee4ec0361a931c339cc9379b351a87a 100644 (file)
--- a/source/auth/auth.c
+++ b/source/auth/auth.c
@@ -131,7 +131,10 @@ uint32 check_password(const auth_usersupplied_info *user_info, auth_serversuppli
        }
        
        if (nt_status == NT_STATUS_NOPROBLEMO) {
+               /* We might not be root if we are an RPC call */
+               become_root();
                nt_status = smb_pam_accountcheck(user_info->smb_username.str);
+               unbecome_root();
        }
 
        if (nt_status == NT_STATUS_NOPROBLEMO) {

diff --git a/source/smbd/auth.c b/source/smbd/auth.c
index 851e1f53cffc664ca716fb1a4aa1471c26d9c3a6..4bfbfe65fee4ec0361a931c339cc9379b351a87a 100644 (file)
--- a/source/smbd/auth.c
+++ b/source/smbd/auth.c
@@ -131,7 +131,10 @@ uint32 check_password(const auth_usersupplied_info *user_info, auth_serversuppli
        }
        
        if (nt_status == NT_STATUS_NOPROBLEMO) {
+               /* We might not be root if we are an RPC call */
+               become_root();
                nt_status = smb_pam_accountcheck(user_info->smb_username.str);
+               unbecome_root();
        }
 
        if (nt_status == NT_STATUS_NOPROBLEMO) {