]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
dm snapshot: fix lockup in dm_exception_table_exit
authorMikulas Patocka <mpatocka@redhat.com>
Wed, 20 Mar 2024 17:43:11 +0000 (18:43 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 13 Apr 2024 10:58:44 +0000 (12:58 +0200)
[ Upstream commit 6e7132ed3c07bd8a6ce3db4bb307ef2852b322dc ]

There was reported lockup when we exit a snapshot with many exceptions.
Fix this by adding "cond_resched" to the loop that frees the exceptions.

Reported-by: John Pittman <jpittman@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/md/dm-snap.c

index 41735a25d50aab399549e61b2a1455c3a5c71dbb..de73fe79640fd571d2ec127524e7225a9c1eba85 100644 (file)
@@ -685,8 +685,10 @@ static void dm_exception_table_exit(struct dm_exception_table *et,
        for (i = 0; i < size; i++) {
                slot = et->table + i;
 
-               hlist_bl_for_each_entry_safe(ex, pos, n, slot, hash_list)
+               hlist_bl_for_each_entry_safe(ex, pos, n, slot, hash_list) {
                        kmem_cache_free(mem, ex);
+                       cond_resched();
+               }
        }
 
        vfree(et->table);