]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: ethernet: litex: use devm_register_netdev() to register netdev
authorInochi Amaoto <inochiama@gmail.com>
Fri, 27 Feb 2026 00:33:47 +0000 (08:33 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 28 Feb 2026 03:25:15 +0000 (19:25 -0800)
Use devm_register_netdev to avoid unnecessary remove() callback in
platform_driver structure.

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20260227003351.752934-2-inochiama@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/litex/litex_liteeth.c

index 829a4b828f8e22283355f848495cab23c5d20e1e..67ad1058c2ab6da0236b1bf6aaadb376c87a96e1 100644 (file)
@@ -232,6 +232,7 @@ static void liteeth_setup_slots(struct liteeth *priv)
 
 static int liteeth_probe(struct platform_device *pdev)
 {
+       struct device *dev = &pdev->dev;
        struct net_device *netdev;
        void __iomem *buf_base;
        struct liteeth *priv;
@@ -282,7 +283,7 @@ static int liteeth_probe(struct platform_device *pdev)
 
        netdev->netdev_ops = &liteeth_netdev_ops;
 
-       err = register_netdev(netdev);
+       err = devm_register_netdev(dev, netdev);
        if (err) {
                dev_err(&pdev->dev, "Failed to register netdev %d\n", err);
                return err;
@@ -294,13 +295,6 @@ static int liteeth_probe(struct platform_device *pdev)
        return 0;
 }
 
-static void liteeth_remove(struct platform_device *pdev)
-{
-       struct net_device *netdev = platform_get_drvdata(pdev);
-
-       unregister_netdev(netdev);
-}
-
 static const struct of_device_id liteeth_of_match[] = {
        { .compatible = "litex,liteeth" },
        { }
@@ -309,7 +303,6 @@ MODULE_DEVICE_TABLE(of, liteeth_of_match);
 
 static struct platform_driver liteeth_driver = {
        .probe = liteeth_probe,
-       .remove = liteeth_remove,
        .driver = {
                .name = DRV_NAME,
                .of_match_table = liteeth_of_match,