iio: dac: ad5504: introduce local dev pointer

Replace &spi->dev with a local dev pointer to shorten lines, fix
alignment, and improve overall readability in the probe function.

Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c
index 03ce37e2c616a0b163ba82afd9e7f99dc416ba47..5e586185d857938b8a8744e3522dc5380ebc294a 100644 (file)
--- a/drivers/iio/dac/ad5504.c
+++ b/drivers/iio/dac/ad5504.c
@@ -270,25 +270,26 @@ static const struct iio_chan_spec ad5504_channels[] = {
 
 static int ad5504_probe(struct spi_device *spi)
 {
-       const struct ad5504_platform_data *pdata = dev_get_platdata(&spi->dev);
+       struct device *dev = &spi->dev;
+       const struct ad5504_platform_data *pdata = dev_get_platdata(dev);
        struct iio_dev *indio_dev;
        struct ad5504_state *st;
        int ret;
 
-       indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
+       indio_dev = devm_iio_device_alloc(dev, sizeof(*st));
        if (!indio_dev)
                return -ENOMEM;
 
        st = iio_priv(indio_dev);
 
-       ret = devm_regulator_get_enable_read_voltage(&spi->dev, "vcc");
+       ret = devm_regulator_get_enable_read_voltage(dev, "vcc");
        if (ret < 0 && ret != -ENODEV)
                return ret;
        if (ret == -ENODEV) {
                if (pdata->vref_mv)
                        st->vref_mv = pdata->vref_mv;
                else
-                       dev_warn(&spi->dev, "reference voltage unspecified\n");
+                       dev_warn(dev, "reference voltage unspecified\n");
        } else {
                st->vref_mv = ret / 1000;
        }
@@ -304,17 +305,17 @@ static int ad5504_probe(struct spi_device *spi)
        indio_dev->modes = INDIO_DIRECT_MODE;
 
        if (spi->irq) {
-               ret = devm_request_threaded_irq(&spi->dev, spi->irq,
-                                          NULL,
-                                          &ad5504_event_handler,
-                                          IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
-                                          spi_get_device_id(st->spi)->name,
-                                          indio_dev);
+               ret = devm_request_threaded_irq(dev, spi->irq,
+                                               NULL,
+                                               &ad5504_event_handler,
+                                               IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+                                               spi_get_device_id(st->spi)->name,
+                                               indio_dev);
                if (ret)
                        return ret;
        }
 
-       return devm_iio_device_register(&spi->dev, indio_dev);
+       return devm_iio_device_register(dev, indio_dev);
 }
 
 static const struct spi_device_id ad5504_id[] = {