spi: pxa2xx: Add missed security checks

[ Upstream commit 5eb263ef08b5014cfc2539a838f39d2fd3531423 ]

pxa2xx_spi_init_pdata misses checks for devm_clk_get and
platform_get_irq.
Add checks for them to fix the bugs.

Since ssp->clk and ssp->irq are used in probe, they are mandatory here.
So we cannot use _optional() for devm_clk_get and platform_get_irq.

Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Link: https://lore.kernel.org/r/20191109080943.30428-1-hslester96@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
index bb6a14d1ab0f929d6e4573573be92db15e631acc..2e73d75a6ac507c5f37dbfbd0ad3489a62680538 100644 (file)
--- a/drivers/spi/spi-pxa2xx.c
+++ b/drivers/spi/spi-pxa2xx.c
@@ -1565,7 +1565,13 @@ pxa2xx_spi_init_pdata(struct platform_device *pdev)
 #endif
 
        ssp->clk = devm_clk_get(&pdev->dev, NULL);
+       if (IS_ERR(ssp->clk))
+               return NULL;
+
        ssp->irq = platform_get_irq(pdev, 0);
+       if (ssp->irq < 0)
+               return NULL;
+
        ssp->type = type;
        ssp->pdev = pdev;
        ssp->port_id = pxa2xx_spi_get_port_id(adev);