]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mtd: rawnand: atmel: Fix dma_mapping_error() address
authorThomas Fourier <fourier.thomas@gmail.com>
Wed, 2 Jul 2025 06:45:11 +0000 (08:45 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 15 Aug 2025 14:39:13 +0000 (16:39 +0200)
[ Upstream commit e1e6b933c56b1e9fda93caa0b8bae39f3f421e5c ]

It seems like what was intended is to test if the dma_map of the
previous line failed but the wrong dma address was passed.

Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver")
Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
Rule: add
Link: https://lore.kernel.org/stable/20250702064515.18145-2-fourier.thomas%40gmail.com
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mtd/nand/raw/atmel/nand-controller.c

index dedcca87defc7af6bc1972abe7c50b565eb19422..84ab4a83cbd68606c4c96641e24952278b1a3a59 100644 (file)
@@ -373,7 +373,7 @@ static int atmel_nand_dma_transfer(struct atmel_nand_controller *nc,
        dma_cookie_t cookie;
 
        buf_dma = dma_map_single(nc->dev, buf, len, dir);
-       if (dma_mapping_error(nc->dev, dev_dma)) {
+       if (dma_mapping_error(nc->dev, buf_dma)) {
                dev_err(nc->dev,
                        "Failed to prepare a buffer for DMA access\n");
                goto err;