genirq/test: Fail early if interrupt request fails

Requesting an interrupt is part of the basic test setup. If it fails, most
of the subsequent tests are likely to fail, and the output gets noisy.

Use "assert" to fail early.

Signed-off-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: David Gow <davidgow@google.com>
Link: https://lore.kernel.org/all/20250822190140.2154646-4-briannorris@chromium.org

diff --git a/kernel/irq/irq_test.c b/kernel/irq/irq_test.c
index f8f4532c28055e99c63b5950f159f4c6c783fa62..56baeb5041d6b015d706980ecb613610842ff359 100644 (file)
--- a/kernel/irq/irq_test.c
+++ b/kernel/irq/irq_test.c
@@ -71,7 +71,7 @@ static void irq_disable_depth_test(struct kunit *test)
        KUNIT_ASSERT_PTR_NE(test, desc, NULL);
 
        ret = request_irq(virq, noop_handler, 0, "test_irq", NULL);
-       KUNIT_EXPECT_EQ(test, ret, 0);
+       KUNIT_ASSERT_EQ(test, ret, 0);
 
        KUNIT_EXPECT_EQ(test, desc->depth, 0);
 
@@ -95,7 +95,7 @@ static void irq_free_disabled_test(struct kunit *test)
        KUNIT_ASSERT_PTR_NE(test, desc, NULL);
 
        ret = request_irq(virq, noop_handler, 0, "test_irq", NULL);
-       KUNIT_EXPECT_EQ(test, ret, 0);
+       KUNIT_ASSERT_EQ(test, ret, 0);
 
        KUNIT_EXPECT_EQ(test, desc->depth, 0);
 
@@ -106,7 +106,7 @@ static void irq_free_disabled_test(struct kunit *test)
        KUNIT_EXPECT_GE(test, desc->depth, 1);
 
        ret = request_irq(virq, noop_handler, 0, "test_irq", NULL);
-       KUNIT_EXPECT_EQ(test, ret, 0);
+       KUNIT_ASSERT_EQ(test, ret, 0);
        KUNIT_EXPECT_EQ(test, desc->depth, 0);
 
        free_irq(virq, NULL);
@@ -134,7 +134,7 @@ static void irq_shutdown_depth_test(struct kunit *test)
        KUNIT_ASSERT_PTR_NE(test, data, NULL);
 
        ret = request_irq(virq, noop_handler, 0, "test_irq", NULL);
-       KUNIT_EXPECT_EQ(test, ret, 0);
+       KUNIT_ASSERT_EQ(test, ret, 0);
 
        KUNIT_EXPECT_TRUE(test, irqd_is_activated(data));
        KUNIT_EXPECT_TRUE(test, irqd_is_started(data));
@@ -191,7 +191,7 @@ static void irq_cpuhotplug_test(struct kunit *test)
        KUNIT_ASSERT_PTR_NE(test, data, NULL);
 
        ret = request_irq(virq, noop_handler, 0, "test_irq", NULL);
-       KUNIT_EXPECT_EQ(test, ret, 0);
+       KUNIT_ASSERT_EQ(test, ret, 0);
 
        KUNIT_EXPECT_TRUE(test, irqd_is_activated(data));
        KUNIT_EXPECT_TRUE(test, irqd_is_started(data));