Treat absent argument to crypto_log_errors as a bug.

diff --git a/src/common/crypto.c b/src/common/crypto.c
index 71cab24d1d76990db10a03ba7512583c11f8ccc2..24a9590cd696b1d560b1d9d49fb897e65b742393 100644 (file)
--- a/src/common/crypto.c
+++ b/src/common/crypto.c
@@ -171,13 +171,9 @@ crypto_log_errors(int severity, const char *doing)
     if (!msg) msg = "(null)";
     if (!lib) lib = "(null)";
     if (!func) func = "(null)";
-    if (doing) {
-      tor_log(severity, LD_CRYPTO, "crypto error while %s: %s (in %s:%s)",
+    if (BUG(!doing)) doing = "(null)";
+    tor_log(severity, LD_CRYPTO, "crypto error while %s: %s (in %s:%s)",
               doing, msg, lib, func);
-    } else {
-      tor_log(severity, LD_CRYPTO, "crypto error: %s (in %s:%s)",
-              msg, lib, func);
-    }
   }
 }