]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-44022: Improve the regression test. (GH-26503)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Thu, 3 Jun 2021 04:04:20 +0000 (21:04 -0700)
committerGitHub <noreply@github.com>
Thu, 3 Jun 2021 04:04:20 +0000 (21:04 -0700)
It wasn't actually detecting the regression due to the
assertion being too lenient.
(cherry picked from commit e60ab843cbb016fb6ff8b4f418641ac05a9b2fcc)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Lib/test/test_httplib.py

index e9272569ecc531197901ddcb017dedd3cafdde56..8265b8d1d6d2dd77c2977525325d2e75c56277de 100644 (file)
@@ -1186,7 +1186,12 @@ class BasicTest(TestCase):
             'r\n' * 32768
         )
         resp = client.HTTPResponse(FakeSocket(body))
-        self.assertRaises(client.HTTPException, resp.begin)
+        with self.assertRaises(client.HTTPException) as cm:
+            resp.begin()
+        # We must assert more because other reasonable errors that we
+        # do not want can also be HTTPException derived.
+        self.assertIn('got more than ', str(cm.exception))
+        self.assertIn('headers', str(cm.exception))
 
     def test_overflowing_chunked_line(self):
         body = (