]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/i915/psr: fix pipe to vblank conversion
authorJani Nikula <jani.nikula@intel.com>
Thu, 6 Nov 2025 20:00:00 +0000 (22:00 +0200)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Mon, 10 Nov 2025 15:12:31 +0000 (10:12 -0500)
First, we can't assume pipe == crtc index. If a pipe is fused off in
between, it no longer holds. intel_crtc_for_pipe() is the only proper
way to get from a pipe to the corresponding crtc.

Second, drivers aren't supposed to access or index drm->vblank[]
directly. There's drm_crtc_vblank_crtc() for this.

Use both functions to fix the pipe to vblank conversion.

Fixes: f02658c46cf7 ("drm/i915/psr: Add mechanism to notify PSR of pipe enable/disable")
Cc: Jouni Högander <jouni.hogander@intel.com>
Cc: stable@vger.kernel.org # v6.16+
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
Link: https://patch.msgid.link/20251106200000.1455164-1-jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
(cherry picked from commit 2750f6765d6974f7e163c5d540a96c8703f6d8dd)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/i915/display/intel_psr.c

index 10eb93a34cf2e5e789d827a185607fc6dcb2d7ee..d5e0a1e66944b9635fa1e80fcc22425d6274dda9 100644 (file)
@@ -888,7 +888,8 @@ static bool is_dc5_dc6_blocked(struct intel_dp *intel_dp)
 {
        struct intel_display *display = to_intel_display(intel_dp);
        u32 current_dc_state = intel_display_power_get_current_dc_state(display);
-       struct drm_vblank_crtc *vblank = &display->drm->vblank[intel_dp->psr.pipe];
+       struct intel_crtc *crtc = intel_crtc_for_pipe(display, intel_dp->psr.pipe);
+       struct drm_vblank_crtc *vblank = drm_crtc_vblank_crtc(&crtc->base);
 
        return (current_dc_state != DC_STATE_EN_UPTO_DC5 &&
                current_dc_state != DC_STATE_EN_UPTO_DC6) ||