]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Fix memory leak in `EC_GROUP_copy()`
authorWeidong Wang <kenazcharisma@gmail.com>
Mon, 9 Mar 2026 10:19:11 +0000 (05:19 -0500)
committerTomas Mraz <tomas@openssl.org>
Tue, 10 Mar 2026 19:03:49 +0000 (20:03 +0100)
We must free pre_comp before its overwrite.

Fixes: 3aef36ffef89 "Add CRYPTO_EX_DATA; remove EC_EXTRA_DATA"
Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Paul Yang <paulyang.inf@gmail.com>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
MergeDate: Tue Mar 10 19:04:33 2026
(Merged from https://github.com/openssl/openssl/pull/30320)

crypto/ec/ec_lib.c

index 01757f058839444c46e74e8970b423b998426e3f..0760944647b51ab9de39686dc0675aca74422c0d 100644 (file)
@@ -175,6 +175,8 @@ int EC_GROUP_copy(EC_GROUP *dest, const EC_GROUP *src)
     dest->libctx = src->libctx;
     dest->curve_name = src->curve_name;
 
+    EC_pre_comp_free(dest);
+
     /* Copy precomputed */
     dest->pre_comp_type = src->pre_comp_type;
     switch (src->pre_comp_type) {