]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
network: update log messages
authorYu Watanabe <watanabe.yu+github@gmail.com>
Tue, 6 Oct 2020 17:49:11 +0000 (02:49 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Tue, 6 Oct 2020 17:49:17 +0000 (02:49 +0900)
And drop unnecessary log for in_addr_to_string(), as its result is used
only for the consequent logs.

src/network/networkd-address.c

index 9ec8d4af1fabf903a186bec4d0fde34c8ad12072..14a2026e3f7c885d389284738b1e431045562d92 100644 (file)
@@ -1119,19 +1119,19 @@ int manager_rtnl_process_address(sd_netlink *rtnl, sd_netlink_message *message,
 
         r = sd_rtnl_message_addr_get_prefixlen(message, &prefixlen);
         if (r < 0) {
-                log_link_warning_errno(link, r, "rtnl: received address message with invalid prefixlen, ignoring: %m");
+                log_link_warning_errno(link, r, "rtnl: received address message without prefixlen, ignoring: %m");
                 return 0;
         }
 
         r = sd_rtnl_message_addr_get_scope(message, &scope);
         if (r < 0) {
-                log_link_warning_errno(link, r, "rtnl: received address message with invalid scope, ignoring: %m");
+                log_link_warning_errno(link, r, "rtnl: received address message without scope, ignoring: %m");
                 return 0;
         }
 
         r = sd_rtnl_message_addr_get_flags(message, &flags);
         if (r < 0) {
-                log_link_warning_errno(link, r, "rtnl: received address message with invalid flags, ignoring: %m");
+                log_link_warning_errno(link, r, "rtnl: received address message without flags, ignoring: %m");
                 return 0;
         }
 
@@ -1158,9 +1158,7 @@ int manager_rtnl_process_address(sd_netlink *rtnl, sd_netlink_message *message,
                 assert_not_reached("Received unsupported address family");
         }
 
-        r = in_addr_to_string(family, &in_addr, &buf);
-        if (r < 0)
-                log_link_warning_errno(link, r, "Could not print address: %m");
+        (void) in_addr_to_string(family, &in_addr, &buf);
 
         r = sd_netlink_message_read_cache_info(message, IFA_CACHEINFO, &cinfo);
         if (r < 0 && r != -ENODATA) {