]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
comedi: das08_isa: Add sanity checks for I/O base address
authorIan Abbott <abbotti@mev.co.uk>
Fri, 30 Jan 2026 16:47:37 +0000 (16:47 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Apr 2026 13:49:37 +0000 (15:49 +0200)
The "das08_isa" driver uses an admin-supplied configuration option
(`it->options[0]`) to configure the I/O port base address of a supported
board in the DAS08 family.  It currently allows any base address to be
configured but the hardware only supports base addresses (configured by
an on-board DIP switch) in the range 0 to 0x3f0 on 16-byte boundaries.
(Technically, the DIP switches allow 8-byte boundaries, but I do not
think that is advisable given that the boards decode an 16-byte address
range.)

Add a sanity check to ensure the device is not configured at an
unsupported base address.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://patch.msgid.link/20260130170416.49994-13-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/comedi/drivers/das08_isa.c

index 3d43b77cc9f40281523c9cb8c26059c0feab005f..1b022dc10b78ef2036a84ae2b7ae4e6a904ab21b 100644 (file)
@@ -167,7 +167,8 @@ static int das08_isa_attach(struct comedi_device *dev,
        if (!devpriv)
                return -ENOMEM;
 
-       ret = comedi_request_region(dev, it->options[0], board->iosize);
+       ret = comedi_check_request_region(dev, it->options[0], board->iosize,
+                                         0, 0x3ff, board->iosize);
        if (ret)
                return ret;