]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: rtw89: mac: remove A-die off setting for RTL8852C and RTL8922A
authorPing-Ke Shih <pkshih@realtek.com>
Tue, 10 Mar 2026 08:01:36 +0000 (16:01 +0800)
committerPing-Ke Shih <pkshih@realtek.com>
Mon, 16 Mar 2026 06:13:13 +0000 (14:13 +0800)
Fix timing issue of A-die off followed by XTAL off. Otherwise, device might
get lost potentially.

Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20260310080146.31113-4-pkshih@realtek.com
drivers/net/wireless/realtek/rtw89/rtw8852c.c
drivers/net/wireless/realtek/rtw89/rtw8922a.c

index e62a7288c8aa876856f38da89712d390b929bb0c..7ea0a8905282cb005d83062774acf4f5ffa3d81c 100644 (file)
@@ -463,7 +463,7 @@ static int rtw8852c_pwr_off_func(struct rtw89_dev *rtwdev)
        else if (rtwdev->hci.type == RTW89_HCI_TYPE_USB)
                rtw89_write32_clr(rtwdev, R_AX_SYS_PW_CTRL, B_AX_SOP_EDSWR);
 
-       rtw89_write32_set(rtwdev, R_AX_SYS_PW_CTRL, B_AX_XTAL_OFF_A_DIE);
+       rtw89_write32_clr(rtwdev, R_AX_SYS_PW_CTRL, B_AX_XTAL_OFF_A_DIE);
        rtw89_write32_set(rtwdev, R_AX_SYS_SWR_CTRL1, B_AX_SYM_CTRL_SPS_PWMFREQ);
        rtw89_write32_mask(rtwdev, R_AX_SPS_DIG_ON_CTRL0,
                           B_AX_REG_ZCDC_H_MASK, 0x3);
index 36ef3611060279d43d647767740a89563df8c903..a489aaf90f23c779036e9d823e4eba65b915c7f2 100644 (file)
@@ -492,7 +492,7 @@ static int rtw8922a_pwr_off_func(struct rtw89_dev *rtwdev)
                return ret;
 
        rtw89_write32(rtwdev, R_BE_WLLPS_CTRL, 0x0000A1B2);
-       rtw89_write32_set(rtwdev, R_BE_SYS_PW_CTRL, B_BE_XTAL_OFF_A_DIE);
+       rtw89_write32_clr(rtwdev, R_BE_SYS_PW_CTRL, B_BE_XTAL_OFF_A_DIE);
        rtw89_write32_set(rtwdev, R_BE_SYS_PW_CTRL, B_BE_APFM_SWLPS);
        rtw89_write32(rtwdev, R_BE_UDM1, 0);