]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[4306] Added comments about uninitilaized too big arrays
authorFrancis Dupont <fdupont@isc.org>
Mon, 21 Mar 2016 14:41:51 +0000 (15:41 +0100)
committerFrancis Dupont <fdupont@isc.org>
Mon, 21 Mar 2016 14:41:51 +0000 (15:41 +0100)
src/lib/dhcp/tests/pkt4_unittest.cc

index 23ebff2948be02933c0d805913726a1310b8bed0..288881b7192c6ed0590be11f84fdeddc7cfb9ee9 100644 (file)
@@ -519,7 +519,8 @@ TEST_F(Pkt4Test, sname) {
     EXPECT_THROW(pkt4.setSname(NULL, Pkt4::MAX_SNAME_LEN), InvalidParameter);
     EXPECT_THROW(pkt4.setSname(NULL, 0), InvalidParameter);
 
-    // Check that a too long argument generates an exception.
+    // Check that a too long argument generates an exception
+    // (the actual content doesn't matter).
     uint8_t bigsname[Pkt4::MAX_SNAME_LEN + 1];
     EXPECT_THROW(pkt4.setSname(bigsname, Pkt4::MAX_SNAME_LEN + 1), OutOfRange);
 }
@@ -563,7 +564,8 @@ TEST_F(Pkt4Test, file) {
     EXPECT_THROW(pkt4.setFile(NULL, Pkt4::MAX_FILE_LEN), InvalidParameter);
     EXPECT_THROW(pkt4.setFile(NULL, 0), InvalidParameter);
 
-    // Check that a too long argument generates an exception.
+    // Check that a too long argument generates an exception
+    // (the actual content doesn't matter).
     uint8_t bigfile[Pkt4::MAX_FILE_LEN + 1];
     EXPECT_THROW(pkt4.setFile(bigfile, Pkt4::MAX_FILE_LEN + 1), OutOfRange);
 }