]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
Issue #19857: Make sure that test_imaplib reaps server threads even in face of
authorCharles-François Natali <cf.natali@gmail.com>
Sat, 7 Dec 2013 19:27:41 +0000 (20:27 +0100)
committerCharles-François Natali <cf.natali@gmail.com>
Sat, 7 Dec 2013 19:27:41 +0000 (20:27 +0100)
error upon client disconnection.

Lib/test/test_imaplib.py

index bafd62b63d2f7a5bb86be53adde9ba8b2355d9c1..2834963484b1527132d0941663c74d28e1a21ab3 100644 (file)
@@ -211,13 +211,12 @@ class BaseThreadedNetworkedTests(unittest.TestCase):
 
     @contextmanager
     def reaped_pair(self, hdlr):
-        server, thread = self.make_server((support.HOST, 0), hdlr)
-        client = self.imap_class(*server.server_address)
-        try:
-            yield server, client
-        finally:
-            client.logout()
-            self.reap_server(server, thread)
+        with self.reaped_server(hdlr) as server:
+            client = self.imap_class(*server.server_address)
+            try:
+                yield server, client
+            finally:
+                client.logout()
 
     @reap_threads
     def test_connect(self):