]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:torture/smb2: improve error handling in durable_v2_open.c
authorStefan Metzmacher <metze@samba.org>
Fri, 30 Aug 2024 12:22:24 +0000 (14:22 +0200)
committerStefan Metzmacher <metze@samba.org>
Thu, 10 Oct 2024 12:47:33 +0000 (12:47 +0000)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15649
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15651

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source4/torture/smb2/durable_v2_open.c

index 7447dd287a489511a89fb4a2e063b4a11f8e8b19..7eed4327b52e66b2871a3313449e2eb9d0391fec 100644 (file)
 #include "torture/smb2/proto.h"
 #include "librpc/ndr/libndr.h"
 
-#define CHECK_VAL(v, correct) do { \
-       if ((v) != (correct)) { \
-               torture_result(tctx, TORTURE_FAIL, "(%s): wrong value for %s got 0x%x - should be 0x%x\n", \
-                               __location__, #v, (int)v, (int)correct); \
-               ret = false; \
-       }} while (0)
-
-#define CHECK_STATUS(status, correct) do { \
-       if (!NT_STATUS_EQUAL(status, correct)) { \
-               torture_result(tctx, TORTURE_FAIL, __location__": Incorrect status %s - should be %s", \
-                      nt_errstr(status), nt_errstr(correct)); \
-               ret = false; \
-               goto done; \
-       }} while (0)
+#define CHECK_VAL(v, correct) \
+       torture_assert_u64_equal_goto(tctx, v, correct, ret, done, __location__)
+
+#define CHECK_STATUS(status, correct) \
+       torture_assert_ntstatus_equal_goto(tctx, status, correct, ret, done, __location__)
 
 #define CHECK_CREATED(__io, __created, __attribute)                    \
        do {                                                            \