autogen.sh: turn format issues into compiler errors

This protects against undefined behavior from wrongly used conversion
specifiers.

Note: snprintf unit test intentionally uses an empty format string to
test, well, the empt format string. Thus override format-zero-length for
it.

Signed-off-by: Tobias Deiminger <tobias.deiminger@linutronix.de>
fix format error

diff --git a/autogen.sh b/autogen.sh
index cd7b3dd63863a1fb5fedf4da36f9a392a7d3b902..f1740d16630e9623f20b2b48033b6ae587632dbc 100755 (executable)
--- a/autogen.sh
+++ b/autogen.sh
@@ -4,8 +4,10 @@ autoreconf -v -f --install "$(dirname "$0")" || exit 1
 
 CFLAGS="-O2"
 CFLAGS="$CFLAGS -Wall"
+CFLAGS="$CFLAGS -Wformat=2"
 CFLAGS="$CFLAGS -Wextra"
 CFLAGS="$CFLAGS -Werror=discarded-qualifiers"
+CFLAGS="$CFLAGS -Werror=format"
 CFLAGS="$CFLAGS -Werror=implicit-function-declaration"
 CFLAGS="$CFLAGS -Werror=implicit-int"
 CFLAGS="$CFLAGS -Werror=incompatible-pointer-types"

diff --git a/tests/unit/Makefile.am b/tests/unit/Makefile.am
index 95dc5b797e4cec29fcfb9279c908e609a29fa463..d18372d0b9e2f1ffe41d9b609e19f7868180b9e2 100644 (file)
--- a/tests/unit/Makefile.am
+++ b/tests/unit/Makefile.am
@@ -100,6 +100,7 @@ test_stprintf_SOURCES = \
     $(NULL)
 test_stprintf_CFLAGS = \
     $(AM_CFLAGS) \
+    -Wno-format-zero-length \
     $(NULL)
 test_stprintf_LDFLAGS = \
     $(NULL)