s3:lib: Fix memory leak in netapi examples

Found by covscan.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/source3/lib/netapi/examples/common.c b/source3/lib/netapi/examples/common.c
index a1a491e60c2b9580a82d29bb4ba1f87753bbf4fe..997144a34e21be44dda59d9b974fcd93d799f518 100644 (file)
--- a/source3/lib/netapi/examples/common.c
+++ b/source3/lib/netapi/examples/common.c
@@ -126,6 +126,7 @@ char *netapi_read_file(const char *filename, uint32_t *psize)
        }
 
        while (size < maxsize) {
+               char *tmp = NULL;
                size_t newbufsize;
                size_t nread;
 
@@ -136,10 +137,12 @@ char *netapi_read_file(const char *filename, uint32_t *psize)
                        goto fail; /* overflow */
                }
 
-               p = realloc(p, sizeof(char)*newbufsize);
-               if (p == NULL) {
+               tmp = realloc(p, sizeof(char) * newbufsize);
+               if (tmp == NULL) {
+                       free(p);
                        goto fail;
                }
+               p = tmp;
 
                nread = fread(p+size, 1, chunk, file);
                size += nread;
@@ -151,6 +154,7 @@ char *netapi_read_file(const char *filename, uint32_t *psize)
 
        err = ferror(file);
        if (err != 0) {
+               free(p);
                goto fail;
        }