]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
leds: lp8860: Write full EEPROM, not only half of it
authorAlexander Sverdlin <alexander.sverdlin@siemens.com>
Thu, 14 Nov 2024 10:13:59 +0000 (11:13 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Mar 2025 11:47:05 +0000 (12:47 +0100)
commit 0d2e820a86793595e2a776855d04701109e46663 upstream.

I struggle to explain dividing an ARRAY_SIZE() by the size of an element
once again. As the latter equals to 2, only the half of EEPROM was ever
written. Drop the unexplainable division and write full ARRAY_SIZE().

Cc: stable@vger.kernel.org
Fixes: 7a8685accb95 ("leds: lp8860: Introduce TI lp8860 4 channel LED driver")
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
Link: https://lore.kernel.org/r/20241114101402.2562878-1-alexander.sverdlin@siemens.com
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/leds/leds-lp8860.c

index f0533a337bc15c2676a29b0e8386f96473663e88..883c06ce7597b5a0e4e74de2e69b0d5934c7cd34 100644 (file)
@@ -267,7 +267,7 @@ static int lp8860_init(struct lp8860_led *led)
                goto out;
        }
 
-       reg_count = ARRAY_SIZE(lp8860_eeprom_disp_regs) / sizeof(lp8860_eeprom_disp_regs[0]);
+       reg_count = ARRAY_SIZE(lp8860_eeprom_disp_regs);
        for (i = 0; i < reg_count; i++) {
                ret = regmap_write(led->eeprom_regmap,
                                lp8860_eeprom_disp_regs[i].reg,