]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
Removed addbase.__del__ because it can't work.
authorSjoerd Mullender <sjoerd@acm.org>
Tue, 15 Aug 1995 11:33:39 +0000 (11:33 +0000)
committerSjoerd Mullender <sjoerd@acm.org>
Tue, 15 Aug 1995 11:33:39 +0000 (11:33 +0000)
If code keeps a reference to self.fp or any of its methods, you don't
want to close self.fp just because no explicit reference is kept to self.

Lib/urllib.py

index 380a852e14bb2986a67d952a4381b2b335c86ace..f83bafd64d5e3495261aff4af1c09ed67a57164c 100644 (file)
@@ -442,8 +442,12 @@ class addbase:
        def __repr__(self):
                return '<%s at %s whose fp = %s>' % (
                          self.__class__.__name__, `id(self)`, `self.fp`)
-       def __del__(self):
-               self.close()
+# Removed this __del__ because it can't work like this.  If a
+# reference is kept to self.fp or any of its methods, but no reference
+# is kept to self, we don't want to close self.fp (which would happen
+# if this __del__ still existed).
+#      def __del__(self):
+#              self.close()
        def close(self):
                self.read = None
                self.readline = None