Fix a memory leak in reading an expired ed signing key.

Closes 17403.

diff --git a/changes/bug17403 b/changes/bug17403
new file mode 100644 (file)
index 0000000..e83a4a2
--- /dev/null
+++ b/changes/bug17403
@@ -0,0 +1,3 @@
+  o Minor bugfixes (memory leaks):
+    - Fix a memory leak when reading an expired signing key from disk.
+      Fixes bug 17403; bugfix on 0.2.7.2-rc.

diff --git a/src/or/routerkeys.c b/src/or/routerkeys.c
index 765dac883a5dae3961d60f65b3eaacc633b432f2..d88bfca13a5c9978f27f1d72dacb2a0c14023574 100644 (file)
--- a/src/or/routerkeys.c
+++ b/src/or/routerkeys.c
@@ -836,6 +836,8 @@ load_ed_keys(const or_options_t *options, time_t now)
                       INIT_ED_KEY_INCLUDE_SIGNING_KEY_IN_CERT);
     char *fname =
       options_get_datadir_fname2(options, "keys", "ed25519_signing");
+    ed25519_keypair_free(sign);
+    tor_cert_free(sign_cert);
     sign = ed_key_init_from_file(fname,
                                  flags, LOG_WARN,
                                  sign_signing_key_with_id, now,