Bug 4696: Fix leaky String move assignment operator (#858)

The original attempt at fixing String move assignment operator (i.e.
commit 20a04c1) leaked the assigned-to String object memory.

These leaks are measurable even in --disable-optimizations builds.

diff --git a/src/SquidString.h b/src/SquidString.h
index 3bfaa5989a5a38276177f09e5314971c044e03f6..30f23285fee45136f6f5ee8277b2f2648fc37495 100644 (file)
--- a/src/SquidString.h
+++ b/src/SquidString.h
@@ -42,6 +42,7 @@ public:
     String &operator =(String const &);
     String &operator =(String && S) {
         if (this != &S) {
+            clean();
             size_ = S.size_;
             len_ = S.len_;
             buf_ = S.buf_;