]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
import-generator: fix crash with no remote string in systemd.pull=
authorLuca Boccassi <luca.boccassi@gmail.com>
Sun, 24 Aug 2025 16:57:34 +0000 (17:57 +0100)
committerLuca Boccassi <luca.boccassi@gmail.com>
Mon, 25 Aug 2025 18:08:25 +0000 (19:08 +0100)
SYSTEMD_PROC_CMDLINE=rd.systemd.pull=raw,machine,blockdev,bootorigin:rootdisk systemd-import-generator

Follow-up for 0c892214f73584e55bfa3fd8f0d54f631cb527b0

src/import/import-generator.c

index 7b4a96f8a7c977b534006040bfb56ca9cf3df1d3..bf0eaa5c0ea51cbba5e66c56144cf809d0a28c02 100644 (file)
@@ -71,6 +71,8 @@ static int parse_pull_expression(const char *v) {
                 return log_error_errno(r, "Failed to extract local name from pull expression '%s': %m", v);
         if (r == 0)
                 return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "No local string in pull expression '%s'.", v);
+        if (isempty(p))
+                return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "No remote string in pull expression '%s'.", v);
 
         _cleanup_free_ char *remote = strdup(p);
         if (!remote)