s3: torture: Add the tests from resolve_realpath_name() to canonicalize_absolute_path().

canonicalize_absolute_path() has a bug.

In canonicalize_absolute_path()

///a/./././///component/../////path/ -> /a//path

It should go to /a/path. Mark as knownfail.

Adding these tests so I can ultimately remove
resolve_realpath_name() and re-use the existing
canonicalize_absolute_path() code in vfs_widelinks.c

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

diff --git a/selftest/knownfail.d/local_canonicalize_path b/selftest/knownfail.d/local_canonicalize_path
new file mode 100644 (file)
index 0000000..477c60a
--- /dev/null
+++ b/selftest/knownfail.d/local_canonicalize_path
@@ -0,0 +1,2 @@
+samba3.smbtorture_s3.LOCAL-CANONICALIZE-PATH
+

diff --git a/source3/torture/torture.c b/source3/torture/torture.c
index c3f387cd0e258c042ac7e63c39558c865e99696e..aa02163636e7efd81eb0ea05d48a9fbf862a401f 100644 (file)
--- a/source3/torture/torture.c
+++ b/source3/torture/torture.c
@@ -14066,6 +14066,25 @@ static bool run_local_canonicalize_path(int dummy)
                        ".././././",
                        ".././././../../../boo",
                        "./..",
+                       "/",
+                       "/../../",
+                       "/foo/../",
+                       "/./././",
+                       "/./././.",
+                       "/.../././.",
+                       "/./././.foo",
+                       "/./././.foo.",
+                       "/./././foo.",
+                       "/foo/bar/..",
+                       "/foo/bar/../baz/",
+                       "////////////////",
+                       "/////////./././././.",
+                       "/./.././../.boo/../baz",
+                       "/a/component/path",
+                       "/a/component/path/",
+                       "/a/component/path/..",
+                       "/a/component/../path/",
+                       "///a/./././///component/../////path/",
                        NULL
                        };
        const char *dst[] = {
@@ -14077,6 +14096,25 @@ static bool run_local_canonicalize_path(int dummy)
                        "/",
                        "/boo",
                        "/",
+                       "/",
+                       "/",
+                       "/",
+                       "/",
+                       "/",
+                       "/...",
+                       "/.foo",
+                       "/.foo.",
+                       "/foo.",
+                       "/foo",
+                       "/foo/baz",
+                       "/",
+                       "/",
+                       "/baz",
+                       "/a/component/path",
+                       "/a/component/path",
+                       "/a/component",
+                       "/a/path",
+                       "/a/path",
                        NULL
                        };
        unsigned int i;