]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
gpio: rockchip: fix OF node leak in probe()
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Mon, 26 Aug 2024 15:08:32 +0000 (17:08 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Sep 2024 09:11:44 +0000 (11:11 +0200)
[ Upstream commit adad2e460e505a556f5ea6f0dc16fe95e62d5d76 ]

Driver code is leaking OF node reference from of_get_parent() in
probe().

Fixes: 936ee2675eee ("gpio/rockchip: add driver for rockchip gpio")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
Link: https://lore.kernel.org/r/20240826150832.65657-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpio/gpio-rockchip.c

index b35b9604413f0864aaa90d09ceafd34c2e0b3c15..caeb3bdc78f8dbb0f1fdb8aa1c2d525c39af6377 100644 (file)
@@ -713,6 +713,7 @@ static int rockchip_gpio_probe(struct platform_device *pdev)
                return -ENODEV;
 
        pctldev = of_pinctrl_get(pctlnp);
+       of_node_put(pctlnp);
        if (!pctldev)
                return -EPROBE_DEFER;