]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
Revert "core: one step back again, for nspawn we actually can't wait for cgroups... v239-14
authorLukas Nykryn <lnykryn@redhat.com>
Thu, 25 Jun 2015 07:20:59 +0000 (09:20 +0200)
committerLukáš Nykrýn <lnykryn@redhat.com>
Tue, 30 Apr 2019 08:50:20 +0000 (10:50 +0200)
This reverts commit 743970d2ea6d08aa7c7bff8220f6b7702f2b1db7.

RHEL-only
https://bugzilla.redhat.com/show_bug.cgi?id=1141137
https://github.com/systemd/systemd/pull/350

Resolves: #1703485

src/core/unit.c

index cc43ddc4f1137f4c809acc3c925250641e9b0972..d298afb0d4ae26147105474e3bff6531b2778127 100644 (file)
@@ -4579,16 +4579,7 @@ int unit_kill_context(
 
                 } else if (r > 0) {
 
-                        /* FIXME: For now, on the legacy hierarchy, we will not wait for the cgroup members to die if
-                         * we are running in a container or if this is a delegation unit, simply because cgroup
-                         * notification is unreliable in these cases. It doesn't work at all in containers, and outside
-                         * of containers it can be confused easily by left-over directories in the cgroup — which
-                         * however should not exist in non-delegated units. On the unified hierarchy that's different,
-                         * there we get proper events. Hence rely on them. */
-
-                        if (cg_unified_controller(SYSTEMD_CGROUP_CONTROLLER) > 0 ||
-                            (detect_container() == 0 && !unit_cgroup_delegate(u)))
-                                wait_for_exit = true;
+                        wait_for_exit = true;
 
                         if (send_sighup) {
                                 set_free(pid_set);