]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
dns: suppress minor scan-build warnings
authorVictor Julien <victor@inliniac.net>
Wed, 11 Dec 2013 09:31:27 +0000 (10:31 +0100)
committerVictor Julien <victor@inliniac.net>
Thu, 12 Dec 2013 14:59:58 +0000 (15:59 +0100)
These were only used if debug is enabled.

app-layer-dns-tcp.c:407:13: warning: Value stored to 'length' is never read
            length = *data;
app-layer-dns-udp.c:236:13: warning: Value stored to 'length' is never read
            length = *data;

src/app-layer-dns-tcp.c
src/app-layer-dns-udp.c

index 6fbb4fc8cc80d097fbbb16d7abeb1b614f289615..0e7626a65aedd9f4cf56222f704af0a0976e7f49 100644 (file)
@@ -404,8 +404,7 @@ static int DNSReponseParseData(Flow *f, DNSState *dns_state, const uint8_t *inpu
                 goto insufficient_data;
             }
 
-            length = *data;
-            SCLogDebug("length %u", length);
+            SCLogDebug("length %u", *data);
         }
         if (fqdn_offset) {
             fqdn_offset--;
index 4acd168f981e90f529aaf1f89b802118e283f2c7..6202bda46b18f11581807960ebee6d0aa98dda7f 100644 (file)
@@ -233,8 +233,7 @@ static int DNSUDPResponseParse(Flow *f, void *dstate,
                 goto insufficient_data;
             }
 
-            length = *data;
-            SCLogDebug("length %u", length);
+            SCLogDebug("length %u", *data);
         }
         if (fqdn_offset) {
             fqdn_offset--;