]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
GH-95736: fix IsolatedAsyncioTestCase to initialize Runner before calling setup funct...
authorKumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Tue, 16 Aug 2022 15:52:06 +0000 (21:22 +0530)
committerGitHub <noreply@github.com>
Tue, 16 Aug 2022 15:52:06 +0000 (08:52 -0700)
Lib/test/test_unittest/test_async_case.py
Lib/unittest/async_case.py
Misc/NEWS.d/next/Library/2022-08-11-18-22-29.gh-issue-95736.LzRZXe.rst [new file with mode: 0644]

index beadcac070b434d2b9edc7f4dd6d9ed84e5d9526..f59fc760d3812fcb534450867a5f1149a6bca734 100644 (file)
@@ -434,6 +434,21 @@ class TestAsyncCase(unittest.TestCase):
         test.doCleanups()
         self.assertEqual(events, ['asyncSetUp', 'test', 'cleanup'])
 
+    def test_setup_get_event_loop(self):
+        # See https://github.com/python/cpython/issues/95736
+        # Make sure the default event loop is not used
+        asyncio.set_event_loop(None)
+
+        class TestCase1(unittest.IsolatedAsyncioTestCase):
+            def setUp(self):
+                asyncio.get_event_loop_policy().get_event_loop()
+
+            async def test_demo1(self):
+                pass
+
+        test = TestCase1('test_demo1')
+        result = test.run()
+        self.assertTrue(result.wasSuccessful())
 
 if __name__ == "__main__":
     unittest.main()
index a90eed98f871402144f33343037959f225792ba7..8b06fad062094602b0fdddedecbded9732a5db9d 100644 (file)
@@ -116,6 +116,10 @@ class IsolatedAsyncioTestCase(TestCase):
         assert self._asyncioRunner is None, 'asyncio runner is already initialized'
         runner = asyncio.Runner(debug=True)
         self._asyncioRunner = runner
+        # Force loop to be initialized and set as the current loop
+        # so that setUp functions can use get_event_loop() and get the
+        # correct loop instance.
+        runner.get_loop()
 
     def _tearDownAsyncioRunner(self):
         runner = self._asyncioRunner
diff --git a/Misc/NEWS.d/next/Library/2022-08-11-18-22-29.gh-issue-95736.LzRZXe.rst b/Misc/NEWS.d/next/Library/2022-08-11-18-22-29.gh-issue-95736.LzRZXe.rst
new file mode 100644 (file)
index 0000000..abc270f
--- /dev/null
@@ -0,0 +1 @@
+Fix :class:`unittest.IsolatedAsyncioTestCase` to set event loop before calling setup functions. Patch by Kumar Aditya.