]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.14] gh-137017: Ensure `Thread.is_alive()` only returns False after the underlying...
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Tue, 7 Oct 2025 17:37:31 +0000 (19:37 +0200)
committerGitHub <noreply@github.com>
Tue, 7 Oct 2025 17:37:31 +0000 (17:37 +0000)
(cherry picked from commit aa9ceb17215af21ed6618d6f7ccb5bf57ca57101)

Co-authored-by: Abdul <abdulrasheedibrahim47@gmail.com>
Co-authored-by: Sam Gross <colesbury@gmail.com>
Misc/NEWS.d/next/Library/2025-08-01-23-11-25.gh-issue-137017.0yGcNc.rst [new file with mode: 0644]
Modules/_threadmodule.c

diff --git a/Misc/NEWS.d/next/Library/2025-08-01-23-11-25.gh-issue-137017.0yGcNc.rst b/Misc/NEWS.d/next/Library/2025-08-01-23-11-25.gh-issue-137017.0yGcNc.rst
new file mode 100644 (file)
index 0000000..7c2c013
--- /dev/null
@@ -0,0 +1,3 @@
+Fix :obj:`threading.Thread.is_alive` to remain ``True`` until the underlying OS
+thread is fully cleaned up. This avoids false negatives in edge cases
+involving thread monitoring or premature :obj:`threading.Thread.is_alive` calls.
index 775cd704cda4ed2742c733bb7cf3c0ef1e6903f1..26d3c0a2266b718a0a7791bf6a08df9b5c7d01ed 100644 (file)
@@ -690,6 +690,9 @@ PyThreadHandleObject_is_done(PyObject *op, PyObject *Py_UNUSED(dummy))
 {
     PyThreadHandleObject *self = PyThreadHandleObject_CAST(op);
     if (_PyEvent_IsSet(&self->handle->thread_is_exiting)) {
+        if (_PyOnceFlag_CallOnce(&self->handle->once, join_thread, self->handle) == -1) {
+            return NULL;
+        }
         Py_RETURN_TRUE;
     }
     else {